VB6 - Bot: Newb Question

[Warden]

Introduction: So I've been messing around with some old old code. l2uthless 2.00e Beta code to be exact, I got my hands on all the required files but Im having problems with the following Function,

Code: [Select]

Public Function CheckProduct() As Boolean
If Username = vbNullString Then AddChat "You must enter a username.": Exit Function
If Password = vbNullString Then AddChat "You must enter a password.": Exit Function
    If Product <> "RATS" And Product <> "PXES" And Product <> "NB2W" And Product <> "VD2D" And Product <> "PX2D" And Product <> "3RAW" And Product <> "PX3W" Then
        AddChat "You have not entered a valid product."
        AddChat "Valid products: RATS, PXES, NB2W, VD2D, PX2D, 3RAW, PX3W"
        Exit Function
    End If
    If (Product = "RATS" Or Product = "PXES") And (Len(cdkey) <> 13) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If (Product = "NB2W" Or Product = "VD2D") And (Len(cdkey) <> 16) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If Product = "PX2D" And (Len(cdkey) <> 16 Or Len(XPCdKey) <> 16) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If Product = "3RAW" And Len(cdkey) <> 26 Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If Product = "PX3W" And (Len(cdkey) <> 26 Or Len(XPCdKey) <> 26) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    CheckProduct = True
End Function

Keeps telling me "You have to enter a Username", but the Username is defined in the Config.ini

Perhaps the Config was different in 2.00e than it is now? Anyways any help is welcome.

[Myst]

follow the code from where Username is grabbed and debug from there

[Warden]

The only other code I can see relating to the Config file & Username is:

Code: [Select]

Public Function GetStuff(Section As String, Key As String) As String
Dim S As String
S = Space(128)
GetPrivateProfileStringA Section, Key, vbNullString, S, Len(S), App.Path & "\Config.ini"
GetStuff = KillNull(S)
End Function

Public Function WriteStuff(Section As String, Key As String, sString As String)
WritePrivateProfileStringA Section, Key, sString, App.Path & "\Config.ini"
End Function

I need a kick in the right direction.

[Vector]

Hit CTRL + F. Type in "Username = " (without quotes), and make sure "Current project" is clicked, and there you can see where Username is being assigned.

[Warden]

@Vector - Lol, Yeah I did that.

This is the CheckProduct code which is kill the connection

Code: [Select]

Public Function CheckProduct() As Boolean
If Username = vbNullString Then AddChat "You must enter a username.": Exit Function
If Password = vbNullString Then AddChat "You must enter a password.": Exit Function
    If Product <> "RATS" And Product <> "PXES" And Product <> "NB2W" And Product <> "VD2D" And Product <> "PX2D" And Product <> "3RAW" And Product <> "PX3W" Then
        AddChat "You have not entered a valid product."
        AddChat "Valid products: RATS, PXES, NB2W, VD2D, PX2D, 3RAW, PX3W"
        Exit Function
    End If
    If (Product = "RATS" Or Product = "PXES") And (Len(cdkey) <> 13) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If (Product = "NB2W" Or Product = "VD2D") And (Len(cdkey) <> 16) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If Product = "PX2D" And (Len(cdkey) <> 16 Or Len(XPCdKey) <> 16) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If Product = "3RAW" And Len(cdkey) <> 26 Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If Product = "PX3W" And (Len(cdkey) <> 26 Or Len(XPCdKey) <> 26) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    CheckProduct = True
End Function

Below I put AddChat "Checking Product..." before the actual product check, as well I put AddChat "Product Verified" after the actual check is completed.

Code: [Select]

Public Sub mnuConnect_Click()
On Local Error GoTo w_Error
Username = GetStuff("Edited", "Username")
Password = LCase(GetStuff("Edited", "Password"))
cdkey = UCase(GetStuff("Edited", "Cd-Key"))
XPCdKey = UCase(GetStuff("Edited", "XPCd-Key"))
Product = UCase(GetStuff("Edited", "Client"))
Server = LCase(GetStuff("Edited", "Server"))
Home = GetStuff("Edited", "Home Channel")
varProxy = GetStuff("Advanced", "Proxy")
If GetStuff("Misc", "Auto Detect Loads") = "Y" Then ald = True
AddChat "Checking hash files..."
If Not CheckHashes Then Exit Sub
AddChat "All hashes found."
AddChat "Checking Product..."
If Not CheckProduct Then Exit Sub
AddChat "Product Verified."


It never outputs "Product Verified" so the problems seems to be within the first code box.

[DavidK]

There is quite a bit that could go wrong in this, I also lol @ Filip for flooding the public namespace. Please verify all of the variables checked are not null and all if statements evaluate as true.

Try this:

Code: [Select]

Public Function CheckProduct() As Boolean
AddC Username & ";" & Password & ";" & Product & ";" & Len(CDKey) & ";" & Len(XPCdKey)
If Username = vbNullString Then AddChat "You must enter a username.": Exit Function
If Password = vbNullString Then AddChat "You must enter a password.": Exit Function
    If Product <> "RATS" And Product <> "PXES" And Product <> "NB2W" And Product <> "VD2D" And Product <> "PX2D" And Product <> "3RAW" And Product <> "PX3W" Then
        AddChat "You have not entered a valid product."
        AddChat "Valid products: RATS, PXES, NB2W, VD2D, PX2D, 3RAW, PX3W"
        Exit Function
    End If
    If (Product = "RATS" Or Product = "PXES") And (Len(cdkey) <> 13) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If (Product = "NB2W" Or Product = "VD2D") And (Len(cdkey) <> 16) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If Product = "PX2D" And (Len(cdkey) <> 16 Or Len(XPCdKey) <> 16) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If Product = "3RAW" And Len(cdkey) <> 26 Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    If Product = "PX3W" And (Len(cdkey) <> 26 Or Len(XPCdKey) <> 26) Then AddChat "You have not entered a valid cd-key for this product.": Exit Function
    CheckProduct = True
End Function

If you still can't find it out, message back the result and I'll help you figure it out.

[Loud]

Debug it line by line bro. Like a programmer would do.

[eX.Pro]

Debug what??? any problem will be added to the chat box....
your config should look like:

Code: [Select]

[Edited]
Username=Warden
Password=fags
Cd-Key=0000000000000
Client=3RAW
etc....


[Warden]

@Helm - Im assuming the first AddC line is suppose to output the Username & Password on screen, but all its outputting is the ;'s

So this code = fail, somewhere thats what I get for trying to avoid BNCSUtil.dll

[DavidK]

Debug it line by line bro. Like a programmer would do.

That's what we call a last ditch effort, which is only used when your programming world breaks down. It's a time consuming anger filled attempt usually ending in a facepalm.

@Helm - Im assuming the first AddC line is suppose to output the Username & Password on screen, but all its outputting is the ;'s

So this code = fail, somewhere thats what I get for trying to avoid BNCSUtil.dll

Make sure you have your config in the right place: App.Path & "\Config.ini"

In other words, the same place as the compiled exe.

[Warden]

Debug it line by line bro. Like a programmer would do.

That's what we call a last ditch effort, which is only used when your programming world breaks down. It's a time consuming anger filled attempt usually ending in a facepalm.

@Helm - Im assuming the first AddC line is suppose to output the Username & Password on screen, but all its outputting is the ;'s

So this code = fail, somewhere thats what I get for trying to avoid BNCSUtil.dll

Make sure you have your config in the right place: App.Path & "\Config.ini"

In other words, the same place as the compiled exe.

Everythings lined up wheres its supposed to be, only think I can think of is that where this is l2ops 2.00 source it might be pulling from the config.ini file a little different than the newer versions.

[DavidK]

The problem is with the following code:

Code: [Select]

Username = GetStuff("Edited", "Username")
Password = LCase(GetStuff("Edited", "Password"))
cdkey = UCase(GetStuff("Edited", "Cd-Key"))
XPCdKey = UCase(GetStuff("Edited", "XPCd-Key"))
Product = UCase(GetStuff("Edited", "Client"))
Server = LCase(GetStuff("Edited", "Server"))
Home = GetStuff("Edited", "Home Channel")
The code is looking in a different section than your config uses. In other words, It's looking for "Edited", but you need "MAIN".

do a search for [[ GetStuff(" ]] and make sure they are all go [[ GetStuff("MAIN", ]]

[Warden]

The problem is with the following code:

Code: [Select]

Username = GetStuff("Edited", "Username")
Password = LCase(GetStuff("Edited", "Password"))
cdkey = UCase(GetStuff("Edited", "Cd-Key"))
XPCdKey = UCase(GetStuff("Edited", "XPCd-Key"))
Product = UCase(GetStuff("Edited", "Client"))
Server = LCase(GetStuff("Edited", "Server"))
Home = GetStuff("Edited", "Home Channel")
The code is looking in a different section than your config uses. In other words, It's looking for "Edited", but you need "MAIN".

do a search for [[ GetStuff(" ]] and make sure they are all go [[ GetStuff("MAIN", ]]

Thanks for spotting it Helm, by the way I changed that value in my config from l2uthless Ops -> ***** -> Edited

Apparently the Source was setup weirdly for single profile use. All that remains now is to define variables from the code in the config and, from what Helm has said, update the login sequence since this source used BnetAuth.dll & NLS.dll

[eX.Pro]

Took you time to figure it, like i didn't give a hint about that, couple post above...

Apparently the Source was setup weirdly for single profile use.

EDIT: Because its single profile.

[pikachu]

Solution: don't steal old vb6 code.

[DavidK]

Solution: don't steal old vb6 code.

He didn't steal it, however I can't say the same about your lottery victory!

[NouN]

Solution: don't steal old vb6 code.

Yea good idea

[Mike]

I don't think it counts as stealing since:
1) The source is public.
2) He mentioned what bot it's from and what he is trying to do (Giving credit)

I do however think it's foolish to even bother to update an old ruthless source especially since your having trouble with the simplest part -.- If you are just trying to learn it's fine but if you have the inclination to actually use what your coding to moderate a channel i'd have to say the end result won't be anywhere near what the newest build of ruthless ops offers in terms of performance.

[Warden]

I don't think it counts as stealing since:
1) The source is public.
2) He mentioned what bot it's from and what he is trying to do (Giving credit)

I do however think it's foolish to even bother to update an old ruthless source especially since your having trouble with the simplest part -.- If you are just trying to learn it's fine but if you have the inclination to actually use what your coding to moderate a channel i'd have to say the end result won't be anywhere near what the newest build of ruthless ops offers in terms of performance.

Im pretty much learning as I go, I don't expect it to be superior to l2uthless 2.13c. Hell, it probably won't even compare to 2.11. Its more of a learning project, if I get things working. I might consider doing my own from scratch, etc. I have figured the problem out I was having, thanks to helm and, now all that remains is to swap out the BnetAuth.dll & NLS.dll for BNCSutil. Not to mention I will be able to code in my own things as I see fit, integrate other things that I want in a bot. If I ever get it working, I will release the source for every previous version of the bot. Perhaps even make it as an open source project for the community much like how Linux is done. But these are all ideas, until I get it working they really don't have any validity to them. I will probably need a little help here and there, if anyone is willing to help it would be greatly appreciated. While snobby remarks are frowned upon, as after all I am only trying to learn.

[l2k-Shadow]

Just note that the 2.00e source is from the time when I was learning how to code (more than 5 years ago). I greatly discourage you using it as a base for any serious project. It is inefficient, slow, and shows very childish coding style. That being said, I do encourage you to learn from it, and I hope you succeed in your endeavors. Once you feel comfortable, you definitely should think about starting your own bot from scratch. l2uthless v2.1x does not use any of < v2.1 code. I completely rewrote it.

[Warden]

Just note that the 2.00e source is from the time when I was learning how to code (more than 5 years ago). I greatly discourage you using it as a base for any serious project. It is inefficient, slow, and shows very childish coding style. That being said, I do encourage you to learn from it, and I hope you succeed in your endeavors. Once you feel comfortable, you definitely should think about starting your own bot from scratch. l2uthless v2.1x does not use any of < v2.1 code. I completely rewrote it.

Do you have any of the v2.1x Sources kicking around?

[Mesiah]

You can have the source to stonerbot, i've run out of time for developing it. The code is good and easy to follow, the connection stuff is current, and it does everythinggg besides multiprofile. I started it, havn't finished. If you know how to index sockets, i'd be glad to forward it to you.

[ben_fb]

The only reason the 2.00 source is available is because it was leaked. The leaked copy had a backdoor of some sort so l2k-shadow released another copy of the 2.00 source. I'm not implying guilt or innocence, I don't know where the leak came from specifically, just that it ended up public at some point. That being said, I wouldn't expect the best work from it.

But seriously everyone, get off the whole 'stop stealing source codes' crap because every one borrows snippets every once in awhile. Why would one spend hours doing research that has already been done? As long as you know HOW to do the work, is all that matters. I wrote the "GetStuff" function, was in my first released source a long long time ago. But guess where I got it from ... api-guide getprivateprofilestring example, it's all there just not in a function.

Point I'm trying to make is: Learning from other source codes is typically good. Also, I would definitely refer to a project that is coded better to help yourself. If you need a current working source my project is available, http://radracer.us/otp/update_checks/ano/files/ano_src.zip - It's not pure genius but everything works and it's very well commented. If Mesiah is offering his source as well I would grab that too.

[pikachu]

Stop reviving dead threads.

Regardless of whether or not it's "stealing" (we can debate this ad infinitum), the main point is that Visual Basic 6.0 is retired and unsupported as of 2005.  It's been half a decade since Microsoft said nobody should be learning or using this piece of shit.  There's literally no excuse for starting to pick this up as a language now or ever creating a new project in it.  Microsoft has come out with four full versions of Visual Basic since the release of 6.0.  That's pretty much akin to still using Windows 98 (6.0 was released in 1998)--which is just absolutely absurd.

The only two groups of people who still use old versions of Visual Basic are Battle.net bot developers and Microsoft Access developers--all of whom should be shot.

[ben_fb]

Oops I didn't mean to bring up an old thread, it was on the first page of topics so I thought it was recent without looking at the date - my bad.